PDFCLOUD-5552 Add client methods to import and export PDF form data#17
Merged
datalogics-kam merged 8 commits intopdfrest:mainfrom Feb 18, 2026
Merged
Conversation
datalogics-cgreen
changed the title
datalogics-cgreen
force-pushed
the
pdfcloud-5464-form-data
branch
from
ae74720 to
db03096
Compare
datalogics-kam
requested changes
Feb 17, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
Locally run Codex PR Review Auditor had these findings; please remediate.
Also, should the live testing use more form types for input?
And make sure that all cases of exporting forms are enumerated.
- [P1]
export_form_dataacceptsxdp/xfdlocally even though the live API rejects those for PDF inputs.
Evidence:
- Local type allows them:
/Users/kam/src/dl/pdfrest-python/src/pdfrest/types/public.py:131 - Payload enforces only that literal type (no PDF-specific format guard):
/Users/kam/src/dl/pdfrest-python/src/pdfrest/models/_internal.py:1030 - Live test explicitly expects server failure for
xdp:/Users/kam/src/dl/pdfrest-python/tests/live/test_live_export_form_data.py:75
Risk: callers get avoidable runtimePdfRestApiErrorinstead of local validation feedback.
- [P2] Live export coverage is incomplete for strict literal/transport parity policy.
Evidence:
- Sync success only parameterizes
xml+xfdf:/Users/kam/src/dl/pdfrest-python/tests/live/test_live_export_form_data.py:24 - Async success tests only
xml:/Users/kam/src/dl/pdfrest-python/tests/live/test_live_export_form_data.py:54 - Public literal includes
fdf,xfdf,xml,xdp,xfd:/Users/kam/src/dl/pdfrest-python/src/pdfrest/types/public.py:131
Risk: transport-specific regressions for untested literals can slip through.
- [P3] Live success assertions don’t fully validate response attributes (type/size/warning) per testing guidance.
Evidence:
- Export live tests assert name/input only:
/Users/kam/src/dl/pdfrest-python/tests/live/test_live_export_form_data.py:47 - Import live tests assert name/type/input IDs but not
size/warning:/Users/kam/src/dl/pdfrest-python/tests/live/test_live_import_form_data.py:65
Risk: weaker signal for API-side behavior changes.
- [P3] Commit messages are not consistently in
area: summaryform.
Evidence from commit log in reviewed range:
Add Import Form Data toolTest Import Form Data toolAdd Export Form Data toolTest Export Form Data
Contributor
|
Chris updates based on recommendations, Kevin merges. |
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
datalogics-cgreen
force-pushed
the
pdfcloud-5464-form-data
branch
from
64dd2a4 to
67cc64e
Compare
✅ Deploy Preview for pdfrest-python ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
datalogics-kam
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds import/export form data endpoints to sync + async clients, wiring to /pdf-with-imported-form-data and /exported-form-data with validated payloads and output naming support.
Introduces ExportDataFormat and internal payload models to enforce allowed MIME types and data formats for form-data workflows.
Adds unit + live coverage for both endpoints (success paths, request customization, validation errors, and async flows), plus a form-data XML fixture